Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/rewrite csharp module #1330

Merged
merged 4 commits into from
Oct 30, 2023
Merged

Feature/rewrite csharp module #1330

merged 4 commits into from
Oct 30, 2023

Conversation

TwoOfTwelve
Copy link
Contributor

Refactored the c-sharp module to use the new framework for the listener as well as for the tests.

The token extraction rules have been modified as follows:

  • every individual using directive results in one token (except those that look like type aliases. Not containing dots or containing generics)
  • else results in an if token (like in java)
  • all loops result in a loop_begin and loop_end token instead of a single token for each type of loop
  • checked and unchecked blocks result in tokens
  • namespaces are mapped into tokens
  • Custom operator functions also create tokens now
  • constructors and operators now get method_begin and method_end tokens for their bodies
  • Local constants now result in a local_variable token
  • Assigning operators like ++ or *= now create assign tokens akin to java

@TwoOfTwelve TwoOfTwelve requested review from tsaglam and Kr0nox October 4, 2023 18:20
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 4, 2023

[JPlag Plagiarism Detector] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

98.1% 98.1% Coverage
0.0% 0.0% Duplication

@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes major Major issue/feature/contribution/change language PR / Issue deals (partly) with new and/or existing languages for JPlag labels Oct 5, 2023
@tsaglam tsaglam merged commit 5183486 into develop Oct 30, 2023
@tsaglam tsaglam deleted the feature/rewrite-csharp-tests branch October 30, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue/PR that involves features, improvements and other changes language PR / Issue deals (partly) with new and/or existing languages for JPlag major Major issue/feature/contribution/change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants