Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve readability of language test results #1224

Merged
merged 4 commits into from
Aug 8, 2023

Conversation

tsaglam
Copy link
Member

@tsaglam tsaglam commented Aug 7, 2023

This PR improves the readability of the language module test results:

  • Display names are used for test categories
  • Token sequences are compared via assertLinesMatch for improved readability in case of failures (see Improve test result visualization for the view file tests #1144)
  • test files are displayed via their names instead of paths
  • JUnit wording "expected"/"actual" is used in favor of "required"/"extracted"

@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change language PR / Issue deals (partly) with new and/or existing languages for JPlag labels Aug 7, 2023
@tsaglam tsaglam requested a review from a team August 7, 2023 11:59
@tsaglam tsaglam marked this pull request as ready for review August 7, 2023 11:59
Copy link
Contributor

@TwoOfTwelve TwoOfTwelve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

The only thing that seems a little of, is that we are now comparing strings instead of enum instances, but I agree that the better output of assertLinesMatch is worth it.

@tsaglam
Copy link
Member Author

tsaglam commented Aug 7, 2023

The only thing that seems a little off, is that we are now comparing strings instead of enum instances, but I agree that the better output of assertLinesMatch is worth it.

Yeah, that is a bit off. I could add a second assertion after the first one where we compare the token directly, then we always have that as a fallback.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 8, 2023

[JPlag Plagiarism Detector] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tsaglam tsaglam merged commit 33cf725 into develop Aug 8, 2023
@tsaglam tsaglam deleted the feature/language-test-naming branch August 8, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue/PR that involves features, improvements and other changes language PR / Issue deals (partly) with new and/or existing languages for JPlag minor Minor issue/feature/contribution/change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants