Simplified names for map functions in AbstractAntlrListener.java

[TwoOfTwelve]

Simplified the names of the mapping functions in AbstractAntlrListener

[brodmo]

What's the difference between mapRange and mapStart? Is it simply the token's length? If so, I would suggest removing mapRange for clarity, as token length isn't used anywhere and should probably be removed altogether

[brodmo]

And what about mapTerminal? I don't really get it. In my mind, there's really only two types of mappings: "simple" mappings (e.g. a variable declarations), where a token is generated when some node is encountered, and scope mappings (e.g. classes), where a begin token is generated when some node is entered and an end token is generated when that same node is exited. I guess these would correspond to mapEnter and mapEnterExit right now.

[TwoOfTwelve]

mapRange indeed only changes the token length. I will check with the maintainers later today, if there is any reason to keep it.

Map terminal is used to map terminal nodes (The nodes created for the tokens defined in the lexer file) of antlr. Sadly the only way to identify them is using integer constants defined by antlr. Writing the listener manually, you can handle them in the visitTerminal method.

For example the kotlin language modules used that to extract tokens like "BREAK". Using the mapTerminal method, that can be done using the new framework:

this.mapTerminal(KotlinParser.BREAK, BREAK);

[sonarqubecloud]

[JPlag Plagiarism Detector] Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

99.3% Coverage
0.0% Duplication

[Kr0nox]

Looks good. Only thing missing is what we discussed in #1159

[tsaglam]

@TwoOfTwelve should we merge this PR now and address the changes discussed above in another PR? Or do we want to include it here?

[brodmo]

@tsaglam please merge this, I'm starting work on the C++ semantic tokens based on it

[tsaglam]

@TwoOfTwelve Lets move the other issues discussed here into another PR!