Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve log readability and parse error reporting #1133

Merged
merged 3 commits into from
Jun 12, 2023
Merged

Improve log readability and parse error reporting #1133

merged 3 commits into from
Jun 12, 2023

Conversation

tsaglam
Copy link
Member

@tsaglam tsaglam commented Jun 12, 2023 •
edited
Loading

Logging improvements:

  • Removes the thread id from the log message (causes a lot of noise during the parallel comparison)
  • When submissions cannot be parsed, warn the user at the end of the JPlag run (as previous errors tend to be missed due to the large log)
  • When the debug mode is used, also state where the erroneous submissions are copied to
  • Improve formatting of logged durations
  • Do not expose internal comparison strategy via log (as it is just more visual noise)
  • Remove superfluous "start comparing" message

@tsaglam tsaglam marked this pull request as ready for review June 12, 2023 09:46
@tsaglam tsaglam requested review from a team June 12, 2023 09:46
Kr0nox
Kr0nox requested changes Jun 12, 2023
View reviewed changes
Copy link
Member

@Kr0nox Kr0nox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just two small things I found

core/src/main/java/de/jplag/JPlag.java Outdated Show resolved Hide resolved
core/src/main/java/de/jplag/TimeUtil.java Show resolved Hide resolved
@tsaglam tsaglam requested a review from Kr0nox June 12, 2023 13:33
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

70.0% 70.0% Coverage
0.0% 0.0% Duplication

@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change labels Jun 12, 2023
@tsaglam tsaglam merged commit 9580752 into develop Jun 12, 2023
@tsaglam tsaglam deleted the feature/logging branch June 12, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TwoOfTwelve TwoOfTwelve TwoOfTwelve left review comments

@Kr0nox Kr0nox Kr0nox approved these changes

Assignees
No one assigned
Labels
enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tsaglam @Kr0nox @TwoOfTwelve