Fix supported C# version in README #1081
Conversation
There was a problem hiding this comment.
You are right; the ANTLR grammar only supports C# 6.
However, the legacy tag is intended for language modules from the legacy era of JPlag, which is pre-v3.0.0. We do not know how well the tokenization is implemented for these language modules and thus do not know how well it performs for plagiarism detection. So I would say leave it as beta. Let me know if you know any newer ANTLR grammar for C#.
tsaglam
added
enhancement
The C# Language class states it supports C# 6, the README previously
stated C# 8 is supported. Expression-bodied not read-only properties
(supported as of C# 7.0 [1]) like this don’t parse:
public int foo { get => 4; }
which means the Language class is right and C# 8 isn’t fully supported.
[1] https://github.com/dotnet/docs/blob/c802a0c56bccdc87908365c0788b3c5ecacea2b3/docs/csharp/programming-guide/statements-expressions-operators/expression-bodied-members.md
|
I’ve updated the PR. However, according to the criteria in the wiki, it counts as |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Thanks! I didn’t know the canonical version of the wiki is in the repo, nice! |
We have not had that for long, but it is really nice. Our CI pushes the docs subdirectory to the internal wiki repo. |
The C# Language class states it supports C# 6, the README previously stated C# 8 is supported. Expression-bodied not read-only properties (supported as of C# 7.0) like this don’t parse:
which means the Language class is right and C# 8 isn’t fully supported. Since the latest version is 11, and the first unsupported version (C# 7) was released over six years ago, also reclassify C# support as “legacy”.