Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print the number of tokens when it’s too little #1067

Merged
merged 1 commit into from
May 10, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions core/src/main/java/de/jplag/SubmissionSet.java
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,8 @@ private void parseBaseCodeSubmission(Submission baseCode) throws BasecodeExcepti
if (!baseCode.parse(options.debugParser())) {
throw new BasecodeException("Could not successfully parse basecode submission!");
} else if (baseCode.getNumberOfTokens() < options.minimumTokenMatch()) {
throw new BasecodeException("Basecode submission contains fewer tokens than minimum match length allows!");
throw new BasecodeException(String.format("Basecode submission contains %d token(s), which is less than the minimum match length (%d)!",
baseCode.getNumberOfTokens(), options.minimumTokenMatch()));
}
logger.trace("Basecode submission parsed!");
long duration = System.currentTimeMillis() - startTime;
Expand Down Expand Up @@ -153,7 +154,8 @@ private void parseSubmissions(List<Submission> submissions) {
}

if (submission.getTokenList() != null && submission.getNumberOfTokens() < options.minimumTokenMatch()) {
logger.error("Submission {} contains fewer tokens than minimum match length allows!", currentSubmissionName);
logger.error("Submission {} contains {} token(s), which is less than the minimum match length ({})!", currentSubmissionName,
submission.getNumberOfTokens(), options.minimumTokenMatch());
submission.setTokenList(null);
tooShort++;
ok = false;
Expand Down