Feature/file encoding #1026
Merged
Feature/file encoding #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure/file-encoding
tsaglam
added
bug
dfuchss
requested changes
Apr 18, 2023
…detection for sets.
|
All requested changes should be implemented. I also made a slight change to the algorithm, it seems to work well with the sample data Timur gave me. |
Can you fix the sonar smells? Also, just resolve the conversations for all issues you addressed in our reviews. |
tsaglam
approved these changes
Apr 25, 2023
Co-authored-by: Dominik Fuchß <[email protected]>
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #746
Uses https://unicode-org.github.io/icu/userguide/conversion/detection.html to detect the file encoding.