Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve duplex error when fetching with stream body #167

Merged
merged 1 commit into from
Aug 27, 2023

Conversation

banyudu
Copy link
Contributor

@banyudu banyudu commented Aug 24, 2023

Without this patch, fetch throws

TypeError: Failed to execute 'fetch' on 'Window':
 The `duplex` member must be specified for a request with a streaming body

when running with a stream body.

fetch(new Request('example1.txt', { method: 'POST' }))  // => ok
fetch(new Request('example1.txt', { method: 'POST', body: '{}' }))  // => exception

This patch converts the stream body to plain text before sending it to native fetch.

Copy link
Collaborator

@TrickyPi TrickyPi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TrickyPi TrickyPi merged commit 1540593 into jpillora:main Aug 27, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants