Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for firefox blob -> array buffer and back again #64

Merged
merged 1 commit into from
Apr 19, 2014

Conversation

brian-mann
Copy link
Contributor

Here's a first crack at fixing the bug in firefox when uploading files. This converts the file blob into an array buffer, and then on the receiving end turns it back into a blob.

I'll be honest I started working with the source code today, but couldn't get grunt-source --server running. I keep getting Fatal error: listen EACCES so I couldn't run any of the tests, so I have no idea if this is breaking other functionality. In my project all seems to be going well so far.

@jpillora
Copy link
Owner

Hey Brian, thanks for the PR, will give it a look over now. Sorry about the bug, that should be grunt-source --server=3000. Will fix that too

@AdamQuadmon
Copy link

Maybe is trying to Open a server on the port 80. Try run the command with sudo (and make sure apache is not running)

@jpillora
Copy link
Owner

There was a breaking change to my grunt JS Lib repo, I think its trying port 0, command above works. Working on this merge here https://github.com/jpillora/xdomain/tree/firefox-blob-fix

@jpillora jpillora merged commit 4acd7a1 into jpillora:gh-pages Apr 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants