Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SEO elements and Instruction on the theme (issue #113) #122

Merged
merged 1 commit into from
Feb 27, 2018

Conversation

dudil
Copy link
Contributor

@dudil dudil commented Feb 11, 2018

  • Add Hugo related SEO parameters to example config.toml
  • Add relevant instructions to the README.md file

Description

Following discussion on issue #113, I've added SEO elements and instructions on how to enable that on the website

Motivation and Context

To allow easy implementation of SEO for theme users, Closes #113
I've also modified the readme.md file to allow easy implementation using the Google/Bing consoles

How Has This Been Tested?

Hugo Version:
0.35

Browser(s):
Safari

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

"name" : "{{ .Title }}",
"headline" : "{{ .Title }}",
"description" : "{{ if .Description }}{{ .Description }}{{ else }}{{if .IsPage}}{{ .Summary }}{{ end }}{{ end }}",
"inLanguage" : "en-US",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use {{ .Lang }} here in case the main Language is not English ?

@statnmap
Copy link
Contributor

Hi. Thanks for the proposition.
I think that the "seo_schema" only needs to appear in "partials/header.html" as this is the main header of the website.
The other headers are for articles or list of articles, which means that they are already under the main header of the website. If we include the "seo_schema" in these headers too, it will be repeated twice or more on pages, which may be worse for SEO.

This is my quick view on it.

@dudil
Copy link
Contributor Author

dudil commented Feb 11, 2018 via email

@pacollins
Copy link
Collaborator

No need to make a new PR. just recommit to feature/issue-113. If you need to know how to reset, let me know.

- Add Hugo related SEO parameters to example config.toml
- Add relevant instructions to the README.md file
@dudil dudil force-pushed the feature/issue-113 branch from 2254e7b to 1b8e687 Compare February 12, 2018 08:22
@dudil
Copy link
Contributor Author

dudil commented Feb 12, 2018

@pacollins - Done - I've recommit the changes.
@statnmap - Good comments, thank you for helping out.
Please let me know if there nay other issues.

@pacollins pacollins merged commit 020882f into jpescador:master Feb 27, 2018
@dudil dudil deleted the feature/issue-113 branch February 27, 2018 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Add SEO parameters to theme
3 participants