Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenGraph meta tags #115

Merged
merged 1 commit into from
Feb 10, 2018
Merged

Conversation

Jean85
Copy link
Contributor

@Jean85 Jean85 commented Feb 7, 2018

Description

This PR adds generig OpenGraph meta tags, using normal configuration parameters.

Motivation and Context

I reworked the theme of our blog in a proper fork: https://github.com/facile-it/hugo-future-imperfect
I'm reporting upstream this change.

How Has This Been Tested?

This modification is currently in production on our blog: https://engineering.facile.it/

Hugo Version: 0.31.1

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the [code style] of this project.
  • My change requires a change to the [documentation].
  • I have updated the documentation, including theme.toml, accordingly.
  • I have read the [Contributing Document].

@pacollins
Copy link
Collaborator

Thanks for this addition! It might be worthwhile to add this to the article/image templates as well.

@pacollins pacollins merged commit 45ef714 into jpescador:master Feb 10, 2018
@Jean85 Jean85 deleted the report-upstream branch February 12, 2018 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants