Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the indicator refresh issues (#33, #40) #51

Merged
merged 1 commit into from
Jan 9, 2015

Conversation

Kernald
Copy link

@Kernald Kernald commented Jan 9, 2015

The TextViews are not always refreshed when their selection states changes. This fixes it, and issues #33 and #40.

@jpardogo
Copy link
Owner

jpardogo commented Jan 9, 2015

Thanks! I will review asap

@jpardogo
Copy link
Owner

jpardogo commented Jan 9, 2015

Just format the code with :

CTRL + ALT + L (Win/ Linux)
OPTION + CMD + L (Mac)

and I merge. Thanks

@Kernald Kernald force-pushed the fix-indicator-refresh branch from 16df1af to 94023e4 Compare January 9, 2015 17:40
@Kernald
Copy link
Author

Kernald commented Jan 9, 2015

Sorry about that. It should be fixed.

@xDragonZ
Copy link

xDragonZ commented Jan 9, 2015

Perfect! I can confirm this fixed the issue 👍 thanks

jpardogo added a commit that referenced this pull request Jan 9, 2015
Fix the indicator refresh issues (#33, #40)
@jpardogo jpardogo merged commit 6308f44 into jpardogo:master Jan 9, 2015
@jpardogo
Copy link
Owner

jpardogo commented Jan 9, 2015

👍

@jpardogo
Copy link
Owner

jpardogo commented Jan 9, 2015

If there are not new issues open next week that we can fix, I will pushed v1.0.8 with this bug fix.

@sockeqwe
Copy link

sockeqwe commented Jan 9, 2015

Does that also fixes the problem of viewpager.setCurrentItem()?

@sockeqwe
Copy link

sockeqwe commented Jan 9, 2015

It seems that not the correct tab is highlighted if I jump to a certain page in ViewPager.setCurrentItem(int position) from Activity.onCreate()... i.e. in Activity.onCreate() i jump to the 5 item in viewpager then the first tab is still marked as highlighted while the viewpager displays the 5 item

@xDragonZ
Copy link

xDragonZ commented Jan 9, 2015

@sockeqwe It fixed that too (i just tested with setCurrentItem too), try download a local copy of the latest code to your project

@sockeqwe
Copy link

sockeqwe commented Jan 9, 2015

@xDragonZ awesome! I strugled over this bug already in astuez original PagerSlidingTabStrip implementation ... Good to see that bug fixed after 2 years :)

@Kernald Kernald deleted the fix-indicator-refresh branch January 9, 2015 19:16
@jpardogo
Copy link
Owner

@xDragonZ @sockeqwe @Kernald Guys, It seems @IGZJcMinarro is getting the same issue again :( #58

@sockeqwe
Copy link

yes, Im facing the same problem in my application

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants