Helm chart vetting #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
jozuenoon
commented
Jul 22, 2019
jozuenoon
commented
- group values.yaml variables
- split ingress into two separate manifests to enable grpcurl to work (reflect endpoint)
- optional certificate for easy minikube deployment
- enable service type switch to workaround nginx ingress problems and get everything working in minikube
- add example etcd deployment with etcd-operator
- split ingress into two separate manifests to enable grpcurl to work (reflect endpoint) - optional certificate for easy minikube deployment - enable service type switch to workaround nginx ingress problems and get everything working in minikube - add example etcd deployment with etcd-operator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.