Add option to upload files by path #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jowilf
requested changes
Jul 29, 2023
sqlalchemy_file/file.py
Outdated
Comment on lines
46
to
50
| content_path: Optional[str] = None, | ||
| filename: Optional[str] = None, | ||
| content_type: Optional[str] = None, | ||
| **kwargs: Dict[str, Any], | ||
| ) -> None: |
There was a problem hiding this comment.
Suggested change
| content_path: Optional[str] = None, | |
| filename: Optional[str] = None, | |
| content_type: Optional[str] = None, | |
| **kwargs: Dict[str, Any], | |
| ) -> None: | |
| filename: Optional[str] = None, | |
| content_type: Optional[str] = None, | |
| content_path: Optional[str] = None, | |
| **kwargs: Dict[str, Any], | |
| ) -> None: |
It might be better to move the content_path parameter down. This way, existing calls to the function won't break
sqlalchemy_file/file.py
Outdated
| @@ -118,6 +130,7 @@ def save_to_storage(self, upload_storage: Optional[str] = None) -> None: | |||
| def store_content( | |||
| self, | |||
| content: Any, | |||
| content_path: Optional[str] = None, | |||
There was a problem hiding this comment.
It might be better to move the content_path parameter down. This way, existing calls to the function won't break
|
I moved |
|
Thank you for your contribution 🎉, I will try to fix the formatting issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids having to load files into memory. I've been running this in production for some time now without issues, but it's certainly possible that this change breaks some behavior I'm not using, in particular when using positional arguments for
Fileconstructor. Let me know what you think.