Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add addEventFilter for analytics-bigquery #1604

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

sadlowskij
Copy link
Contributor

Proposed Changes

This change should give the user more control over what is to be sent to the BigQuery Table. When working with bigger voice apps, multiple events per request can lead to huge amounts of BigQuery table rows that might not be needed in a give case. This filter function gives the user the chance to filter out events by eventType, user, or whatever they want.

If there are any issues with this, feel free to let me know!

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Copy link
Member

@jankoenig jankoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @sadlowskij 🎉

@jankoenig jankoenig merged commit d9fda96 into jovotech:v4/dev Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants