Dmc updates #58
Open
Dmc updates #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…losing project This code needs to be added to ensure all VI's affecting by the Replace With action are loaded into memory and stay in memory for the duration of the build
Added events to indicate "Swapping Libraries" and "Building Item" to make the progress of the build more clear from the Solution Builder UI
This update was missed as part of the last commit
Are you suggesting the reason for not creating the bldcache file on CI machines is that since they rebuild fully no matter what, it's pointless to create the file since it's unused? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
High-level Checklist (if any apply):
Added features to allow skipping the creation of bldcache and to include more update events for the UI. Also fixed a bug where not all changes were maintained in memory due to the potential for some project components to not be in memory when the builder ran.
Why should this Pull Request be merged?
I added a new feature to the top level VI to allow the creation of the bldcache file to be skipped. This is particularly useful in larger CI implementations, as it saves time and resources on each job in the pipeline. The other feature that was added was the inclusion of two addition build events to update the front panel and make the progress more clear to the user.
For bug fixes, I added code to open all VI's in a project when opening the project and close all VI's when closing the project. This is a needed change because not all VI's are immediately in memory when a project opens, so changes to those VI's when swapping source libraries for PPLs have no way of staying in memory and the build does not complete as intended. My methodology for solving this issue is to cast a wide net and load everything, but there may be better options available to stay more efficient.
What testing has been done?
/src/_tests/RunTheTests.viand all tests passedNo additional tests have been added at this time, but the modified code has been used extensively on my part and has been successful in building the desired outputs. Additionally, the outputs of
src/_tests/RunTheTests.vihave not changed with the inclusion of my updates.What Release Build Should This Go In?