Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ArithmeticException in CameraPreview #463

Merged
merged 1 commit into from
Sep 7, 2019

Conversation

lterminiello
Copy link
Contributor

In version 3.6.0 of the lib, we had crashes of ArithmeticException, since we assume that the view has not yet finished drawing and the previewSized method is called

link Issue #334
link Issue #409

@teolemon
Copy link

@rkistner does the solution look good to you ?

@rkistner
Copy link
Member

I haven't yet been able to confirm whether this will fully fix the issue; will need to spend more time on this.

@DevFranck
Copy link

DevFranck commented Aug 30, 2019

Hi @rkistner . I use this beautiful library, but this problem bothers me. Do you intend to merge these patches? Is this library still maintained?
Is there a planned date for version 3.7.0 ?

@ethanwa
Copy link

ethanwa commented Sep 3, 2019

Hi @rkistner . I use this beautiful library, but this problem bothers me. Do you intend to merge these patches? Is this library still maintained?
Is there a planned date for version 3.7.0 ?

I second this. When can your latest changes be merged?

@rkistner
Copy link
Member

rkistner commented Sep 4, 2019

Sorry for the delay, I will look into this and do a new release over the next couple of days.

@DevFranck
Copy link

Sorry for the delay, I will look into this and do a new release over the next couple of days.

No problem @rkistner . I am looking forward to the new version :)

@rkistner rkistner merged commit 1a1c8d0 into journeyapps:master Sep 7, 2019
@maggialejandro-rp
Copy link

Hi @rkistner
Could this path be released in a 3.6.x version? As our project could not me upgraded to support min sdk 24 right now.
Thanks!

@rkistner
Copy link
Member

@maggialejandro-rp You can still use version 4.0.2 with SDK 14. See the instructions here: https://github.com/journeyapps/zxing-android-embedded/blob/master/README.md#zxing-android-embedded

Just make sure to test properly.

pcqpcq added a commit to pcqpcq/zxing-android-embedded that referenced this pull request Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants