Improved buttons #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed odd behaviour where dropdown reapppears when repeatedly clicking search bar - Removed detachable attrubute (for now?) - Corrected Checkstyle - Added test method to author button (dont allow attributes without search terms)
- Fixed odd behaviour where dropdown reapppears when repeatedly clicking search bar - Removed detachable attrubute (for now?) - Corrected Checkstyle - Buttons dont allow adding attributes when prior ones are empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sidenote: I think we should make a item queue for attributes, logical operators and search terms and use that to build a String for the global search bar, instead of building the search from the global search bar string. Lets discuss tomorrow.