Add explicit children prop #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`@types/react` has been updated for react 18 to no longer include an implicit `children` prop on every `Component`. This means `<FlipMove>` is no longer usable with the latest react typings because you must pass `children` to `<FlipMove>` but TypeScript thinks the `<FlipMove>` component doesn't accept any `children`.
|
Thanks @xcv58! |
|
@xcv58 Can you create a release for this change? I am running into this issue with the latest version since it doesn't include this change |
Sorry I don't have that permission to do the release, waiting for this #233 (comment) |
Saw that after posting! Thanks for taking the time to reply. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
@types/reacthas been updated for react 18 to no longer include an implicitchildrenprop on everyComponent. This means<FlipMove>is no longer usable with the latest react typings because you must passchildrento<FlipMove>but TypeScript thinks the<FlipMove>component doesn't accept anychildren.This PR adds an explicit
childrenprop to the typings including a doc comment.Thanks!