Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

centralize getQuote strsplit processing #284

Closed
ethanbsmith opened this issue Nov 4, 2019 · 1 comment · Fixed by #285
Closed

centralize getQuote strsplit processing #284

ethanbsmith opened this issue Nov 4, 2019 · 1 comment · Fixed by #285
Assignees
@joshuaulrich
Milestone
Release 0.4-16

Comments

@ethanbsmith
Copy link
Contributor

ethanbsmith commented Nov 4, 2019 •
edited
Loading

Description

getQuote and getSymbols accept ";" delimited symbols as input. Not all dispatched getQuote implementations handle this. better to consolidate this into the master getQuote function before dispatching to to the sources.

Minimal, reproducible example

getQuote(c("SPY;WYSIWIG"), src="tiingo")
getQuote(c("SPY;WYSIWIG"), src="av")
@ethanbsmith ethanbsmith changed the title not all getQuote sources properly handle ";" delimited input centralize getQuote housekeeping code Nov 5, 2019
@ethanbsmith ethanbsmith mentioned this issue Nov 5, 2019
Merged
@ethanbsmith ethanbsmith changed the title centralize getQuote housekeeping code centralize getQuote strsplit processing Nov 7, 2019
@joshuaulrich joshuaulrich self-assigned this Nov 18, 2019
@joshuaulrich
Copy link
Owner

This is a great idea! We shouldn't repeat the same code when we can move it to the main function.

joshuaulrich added a commit that referenced this issue Nov 18, 2019
@joshuaulrich
Move strsplit to main getQuote function
59607ff 
Centralize strsplit functionality into main getQuote function to avoid
code duplication. Remove strsplit calls from individual functions.

Fixes #284. Closes #285.
@joshuaulrich joshuaulrich added this to the Release 0.4-16 milestone Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshuaulrich joshuaulrich

Labels
None yet
Projects
None yet
Milestone
Release 0.4-16
Development

Successfully merging a pull request may close this issue.

284 added strspl and merge fucntionality to main function
2 participants
@joshuaulrich @ethanbsmith