Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add_TA legend argument cannot be set #205

Closed
helgasoft opened this issue Dec 5, 2017 · 1 comment
Closed

add_TA legend argument cannot be set #205

helgasoft opened this issue Dec 5, 2017 · 1 comment
Labels
enhancement
Milestone
Release 0.4.23

Comments

@helgasoft
Copy link

helgasoft commented Dec 5, 2017 •
edited
Loading

Description

I appears the legend argument of add_TA cannot be changed from default 'auto' to a custom string.

Expected behavior

I hoped add_TA would work like the standard function addTA.

Minimal, reproducible example

getSymbols('T')
chartSeries(T); addTA(EMA(Cl(T)), legend="myEMA")	# does it ok
chart_Series(T); add_TA(EMA(Cl(T)), legend="myEMA") 	   # doesn't
@joshuaulrich joshuaulrich mentioned this issue Apr 16, 2023
Closed
@joshuaulrich joshuaulrich added this to the Release 0.4.23 milestone Apr 16, 2023
@joshuaulrich
Copy link
Owner

This is addressed by the fix for #377. That fix adds a name argument and removes the legend argument. The rationale is:

I tried to pass user-supplied 'legend' values through the plotting functions, but it didn't work seamlessly like it does when passing the 'name' argument.

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Jan 4, 2025
(finance/R-quantmod) Updated 0.4.22 to 0.4.26, NEWS.md not recent
68ff06d 
### Changes in 0.4.25 (2023-08-21)

1. Fix `getQuote.yahoo()` for API changes. Thanks to Ethan B. Smith for the
    report and patch! Also add error message for users in GDPR countries, since
    we cannot automatically consent to GDPR and the request fails without
    consent.
    [#392](joshuaulrich/quantmod#392)
    [#393](joshuaulrich/quantmod#393)
    [#395](joshuaulrich/quantmod#395)

1. Fix `getQuote.yahoo()` when the user only requested metrics that do not have
    have a value for 'regularMarketTime'. Set the value to NA in these cases
    so the output remains the same regardless of whether the endpoint returns
    a 'regularMarketTime' or not. Thanks to @mehdiMBH for the report!
    [#255](joshuaulrich/quantmod#255)

1. Add fields to `getQuote.yahoo()` that are returned when no fields are
    explicitly requested. Thanks to @Courvoisier13 for the report!
    [#335](joshuaulrich/quantmod#335)

1. Add intraday endpoint to `getSymbols.yahoo()`. Thanks to @kapsner for the
    report and patch! Also allow suppressing the warning if more than 7 days
    of data are requested (@eddelbuettel).
    [#351](joshuaulrich/quantmod#351)
    [#381](joshuaulrich/quantmod#381)
    [#399](joshuaulrich/quantmod#399)

1. Add warning if `getSymbols()` is called with tickers that are reserved words
    because accessing them requires back-quotes (e.g. ``NA``).
    [#401](joshuaulrich/quantmod#401)

1. Fix `allReturns()` when 'subset' is specified. Thanks to @Panagis1980 for
    the report!
    [#402](joshuaulrich/quantmod#402)

### Changes in 0.4.24 (2023-07-17)

1. Fix `getSymbols.oanda()` URL. Thanks to @macray76 for the report.
    [#387](joshuaulrich/quantmod#387)

### Changes in 0.4.23 (2023-06-14)

1. Fix `getQuote.yahoo()` error. Thanks to Ethan B. Smith for the report and
    patch!
    [#382](joshuaulrich/quantmod#382)
    [#383](joshuaulrich/quantmod#383)

1. Add `name` argument to `add_TA()`. Thanks to @SamoPP for the suggestion!
    [#377](joshuaulrich/quantmod#377)
    [#205](joshuaulrich/quantmod#205)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Release 0.4.23
Development

No branches or pull requests
2 participants
@joshuaulrich @helgasoft