Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5 #75

Closed
wants to merge 2 commits into from
Closed

Fix #5 #75

wants to merge 2 commits into from

Conversation

joshuanianji
Copy link
Owner

@joshuanianji joshuanianji commented Jan 19, 2022

Attempts to fix #5 by uninstalling npm LOL

npm/cli#3785 (comment)

@netlify
Copy link

netlify bot commented Jan 19, 2022

✔️ Deploy Preview for treehouse-bot ready!

🔨 Explore the source changes: 055fcac

🔍 Inspect the deploy log: https://app.netlify.com/sites/treehouse-bot/deploys/61e84d577523ca000863621b

😎 Browse the preview: https://deploy-preview-75--treehouse-bot.netlify.app

@joshuanianji joshuanianji temporarily deployed to dev January 19, 2022 17:41 Inactive
@joshuanianji
Copy link
Owner Author

Surprisingly, this increases the image size by around 2MB

Screen Shot 2022-01-19 at 10 42 08 AM

@joshuanianji
Copy link
Owner Author

Hmm, looks like npm uninstall -g npm still includes a .npm folder. I don't want to manually remove it because that seems hacky. I think i'll skip this fix and wait for the actual NPM update.

Also, manually installing node by itself seems like more work than necessary.

@joshuanianji joshuanianji deleted the fix-5 branch February 8, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CVE-2021-3807 Vulnerability
1 participant