Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to skip discarded tabs #23

Merged
merged 7 commits into from
Dec 19, 2019
Merged

Conversation

amandamana
Copy link
Contributor

@amandamana amandamana commented Dec 17, 2019

I haven't tested storing and loading the new preference as FireFox seems to prevent temporary add-ons from saving options to permanent storage.
EDIT: it works. I forgot to click 'Save Options'

@joshuacant
Copy link
Owner

Awesome! Thanks for making a PR!

I'll check this out, run it myself for a day or two (I always do this before a new version), then merge and post a new version to AMO.

@amandamana
Copy link
Contributor Author

Sounds great, thanks! I've tested all combinations of the 3 options (skip collapsed, skip discarded, and skip cycling) in various positions and states of the tree.

@amandamana
Copy link
Contributor Author

that was the definitely the last commit for issue #21 I plan to make a new pull request for issue #4 at some time in the future, perhaps next month.

@amandamana
Copy link
Contributor Author

Guess I was wrong about being the last commit. This was only a one-liner so might as well put in here now :)

@joshuacant joshuacant merged commit 8f2467d into joshuacant:master Dec 19, 2019
@amandamana amandamana deleted the patch-2 branch December 20, 2019 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants