Skip to content

Commit

Permalink
N5S3ZarrReader: combine N5ZarrReader logic into a N5AmazonS3Reader su…
Browse files Browse the repository at this point in the history
…bclass

Until there are interfaces, wrappers, or similar composable objects
which allow having both S3 access and Zarr reading, the N5S3ZarrReader
allows a client to explicitly choose the combination of both. This
commit copies methods in order to having a working version of the
reader. Future clean up includes extracting methods to a helper class,
introducing abstract methods to reduce repeated code blocks, and similar.

see: saalfeldlab/n5-aws-s3#10 (comment)
  • Loading branch information
joshmoore committed Oct 20, 2020
1 parent 642b45f commit e651a72
Show file tree
Hide file tree
Showing 3 changed files with 551 additions and 2 deletions.
14 changes: 12 additions & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -92,13 +92,23 @@
</properties>

<dependencies>
<dependency>
<groupId>net.imglib2</groupId>
<artifactId>imglib2</artifactId>
</dependency>
<dependency>
<groupId>org.janelia.saalfeldlab</groupId>
<artifactId>n5</artifactId>
</dependency>
<dependency>
<groupId>net.imglib2</groupId>
<artifactId>imglib2</artifactId>
<groupId>org.janelia.saalfeldlab</groupId>
<artifactId>n5-aws-s3</artifactId>
<version>3.2.0</version>
</dependency>
<dependency>
<groupId>org.janelia.saalfeldlab</groupId>
<artifactId>n5-imglib2</artifactId>
<version>3.5.1</version>
</dependency>
<dependency>
<groupId>org.janelia.saalfeldlab</groupId>
Expand Down
Loading

0 comments on commit e651a72

Please sign in to comment.