fix: make all tests and crates compileable with ratatui 0.28 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 2 2
Lines 136 136
=====================================
Misses 136 136 ☔ View full report in Codecov by Sentry. |
- Frame::size() has been replaced with Frame::area() - Buffer index supports `Into<Position>` - Put back the `default-features = false` for ratatui in Cargo.toml (this makes it possible to use the widgets on other backends than except tui-prompts which requires crossterm)
|
Thanks. I've been meaning to add a dependabot setting that specifically pulls in Ratatui daily rather than weekly, but haven't gotten around to it yet. I updated a few things (deprecations, lints, and some more concise code), and this will be released shortly. |
joshka
pushed a commit
that referenced
this pull request
Aug 9, 2024
## 🤖 New release * `tui-big-text`: 0.5.4 -> 0.5.5 <details><summary><i><b>Changelog</b></i></summary><p> ## `tui-big-text` <blockquote> ## [0.5.5] - 2024-08-09 ### 🐛 Bug Fixes - Update to ratatui 0.28 ([#24](#24)) > Note that for projects that rely on crossterm, Ratatui 0.28.0 now relies internally on Crossterm 0.28.0. > Ratatui release notes highlights: https://ratatui.rs/highlights/v028/ > See ratatui/ratatui#1298 for notes about crossterm compatibility </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
joshka
pushed a commit
that referenced
this pull request
Aug 9, 2024
## 🤖 New release * `tui-widgets`: 0.2.4 -> 0.2.5 <details><summary><i><b>Changelog</b></i></summary><p> ## `tui-widgets` <blockquote> ## [0.2.5] - 2024-08-09 ### 🐛 Bug Fixes - Add missing cfg ([#28](#28)) ### ⚙️ Miscellaneous Tasks - *(tui-big-text)* Release v0.5.5 ([#25](#25)) > ## 🤖 New release > * `tui-big-text`: 0.5.4 -> 0.5.5 > > <details><summary><i><b>Changelog</b></i></summary><p> > > ## `tui-big-text` > <blockquote> > > ## [0.5.5] - 2024-08-09 > > ### 🐛 Bug Fixes > > - Update to ratatui 0.28 > ([[#24](https://github.com/joshka/tui-widgets/pull/24)](https://github.com/joshka/tui-widgets/pull/24)) > > Note that for projects that rely on crossterm, Ratatui 0.28.0 now > relies internally on Crossterm 0.28.0. > > Ratatui release notes highlights: https://ratatui.rs/highlights/v028/ > > See ratatui/ratatui#1298 for notes about > crossterm compatibility > </blockquote> > > > </p></details> > > --- > This PR was generated with > [release-plz](https://github.com/MarcoIeni/release-plz/). </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on one of my projects, I found out, I was not able to build with ratatui 0.28 and any version of tui-big-text.
With this pull request, I want to mak the crates from this repository compilable with ratatui 0.28.
With these two changes, I am able to build my project against ratatui 0.28 and tui-big-text from this branch. And all tests and crates from this repository can be built and run again.
After this branch is merged, all components need new versions, I think.