Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the structure of the config #4

Merged
merged 19 commits into from
Mar 27, 2023
Merged

Change the structure of the config #4

merged 19 commits into from
Mar 27, 2023

Conversation

joshdales
Copy link
Owner

@joshdales joshdales commented Mar 25, 2023

This came up in a dicussion in my PR that made me think that I'd actually got the config structure wrong, and that it wasn't actually going to be as flexible or work the way that people expected it to. So I've changed the config again:

Changes the config so that any and all keys are applicable to each option.

label:
  - any: 
    - changed-files: ['list', 'of', 'globs']
    - base-branch: ['list', 'of', 'regexps']
    - head-branch: ['list', 'of', 'regexps']
  - all:
    - changed-files: ['list', 'of', 'globs']
    - base-branch: ['list', 'of', 'regexps']
    - head-branch: ['list', 'of', 'regexps']

I have updated the readme and added more tests to cover these new cases.

@lucacome
Copy link

works as expected 🙂

@joshdales joshdales force-pushed the another-config-setup branch from c462696 to 8ce1f17 Compare March 27, 2023 20:54
@joshdales joshdales force-pushed the another-config-setup branch from 8ce1f17 to 2f1dfd1 Compare March 27, 2023 21:15
@joshdales joshdales merged commit 7f169bc into main Mar 27, 2023
@joshdales joshdales deleted the another-config-setup branch March 27, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants