Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSR conflict with Symfony #40

Closed
pvdleek opened this issue Jun 30, 2024 · 7 comments · Fixed by #46
Closed

PSR conflict with Symfony #40

pvdleek opened this issue Jun 30, 2024 · 7 comments · Fixed by #46

Comments

@pvdleek
Copy link

pvdleek commented Jun 30, 2024

Hi, I ran into an issue today that the PSR extension conflicts with the Symfony cache component. I therefore had to remove PSR, but as there is no "docker-php-ext-disable" (and it will not be there, see docker-library/php#220 (comment)) I tried "pecl uninstall psr". Unfortunately that created another issue:

PHP Warning:  PHP Startup: Unable to load dynamic library 'psr' (tried: /usr/local/lib/php/extensions/no-debug-non-zts-20230831/psr (Error loading shared library /usr/local/lib/php/extensions/no-debug-non-zts-20230831/psr: No such file or directory), /usr/local/lib/php/extensions/no-debug-non-zts-20230831/psr.so (Error loading shared library /usr/local/lib/php/extensions/no-debug-non-zts-20230831/psr.so: No such file or directory)) in Unknown on line 0

I could of course create a PR for the removal of PSR, but it might be more interesting to have a ENV variable control the installation of PSR (and maybe other extensions).

How do you feel about this?

@joseluisq joseluisq added enhancement New feature or request help wanted Extra attention is needed labels Jul 2, 2024
@joseluisq
Copy link
Owner

It sounds not bad. I'm thinking of something like an ENV to pass a list of extensions (not just PSR) to disable at start-up (remove them eventually).

@joseluisq
Copy link
Owner

On the other hand, being able to turn off extensions at build time should be also a nice feature since not all users want the same amount of extensions to use.

@joseluisq
Copy link
Owner

Feel free to propose something in either case.

@pvdleek
Copy link
Author

pvdleek commented Jul 2, 2024

I think an ENV would do just fine. At this point I would go for a blacklist to disable certain extensions. So in my case I would pass on an ENV "EXTENSION_BLACKLIST" with value "psr" or something like that.
In the mean time I made a copy of this repo, removed PSR and published my own base-image, but I'd rather go back to this repo with the possibility to disable PSR ;)

@pvdleek
Copy link
Author

pvdleek commented Jul 12, 2024

Any progress on this? ;)

@joseluisq
Copy link
Owner

Unfortunately, I couldn't find the time, but if you want to help, just let me know.
Let's see how it goes in the next few days.

@joseluisq
Copy link
Owner

@pvdleek #40 will add support for disabling extensions. Feel free to test it.

@joseluisq joseluisq added extensions v8.1 v8.2 v8.3 and removed help wanted Extra attention is needed labels Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants