OAI Prototype: Remove ClientPipelineExtensions #213
+29
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annelo-msft
commented
Aug 16, 2024
| @@ -44,7 +45,6 @@ internal PipelineMessage CreateCreateChatCompletionRequest(BinaryContent content | |||
| request.Headers.Set("Accept", "application/json"); | |||
| request.Headers.Set("Content-Type", "application/json"); | |||
| request.Content = content; | |||
| message.Apply(options); | |||
There was a problem hiding this comment.
This moves into ClientPipeline.ProcessMessage
annelo-msft
commented
Aug 16, 2024
.dotnet/src/Generated/ChatClient.cs
Outdated
| @@ -35,6 +35,7 @@ internal PipelineMessage CreateCreateChatCompletionRequest(BinaryContent content | |||
| { | |||
| var message = _pipeline.CreateMessage(); | |||
| message.ResponseClassifier = PipelineMessageClassifier200; | |||
| message.ExceptionFactory = _exceptionFactory; | |||
There was a problem hiding this comment.
Custom exception factory is set on the message.
annelo-msft
commented
Aug 16, 2024
| @@ -65,6 +66,7 @@ protected internal ChatClient(ClientPipeline pipeline, string model, Uri endpoin | |||
| _pipeline = pipeline; | |||
| _endpoint = endpoint; | |||
| _telemetry = new OpenTelemetrySource(model, endpoint); | |||
| _exceptionFactory = new OpenAIExceptionFactory(); | |||
There was a problem hiding this comment.
Customization layer sets this in the client constructor, or generated code sets it to ClientResultExceptionFactory.Default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.