-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sparse Matrix LU decomposition using full pivoting #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: lib/type/matrix/SparseMatrix.js
Conflicts: lib/type/matrix/SparseMatrix.js
…parse Conflicts: lib/type/matrix/SparseMatrix.js
josdejong
added a commit
that referenced
this pull request
May 31, 2015
Sparse Matrix LU decomposition using full pivoting
thanks a lot, impressive job again! Do we have to add credit to the SuiteSparse library somewhere (besides references in the code comments)? |
I did not find that information anywhere, I will look in more details and let you know. |
I had a quick look but didn't see anything either. It's at least neat that you included references in the code comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds Sparse Matrix algorithms for LU decomposition using full pivoting to mathjs. The algorithms are a port from SuiteSparse library(C language) to JavaScript. The algorithms have been adapted to work with mathjs arithmetic operations so they will work fine with all supported data types.
An important feature of this implementation is that it adds the ability to order the Sparse Matrix to avoid introducing non-zero entries in the solution keeping the resulting matrices with a density of the same order as the original matrix.
The
lusolve()
function has been modified to accept LU decomposition using full pivoing (A[p,q] = L * U)Only one new public API function is introduced to mathjs (
slu()
). The SuiteSparse library port is kept private to mathjs.