Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new metric prefixes: Q, R, r, and q #3113

Merged
merged 6 commits into from
Jan 10, 2024
+58 −8
Merged

Support new metric prefixes: Q, R, r, and q #3113

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e79b99e
added Q, R, r, q metrix prefixes
AlexEdgcomb Dec 20, 2023
7c2395b
tests added for new prefixes
AlexEdgcomb Dec 21, 2023
0a8181d
removed duplicate tests
AlexEdgcomb Dec 21, 2023
2e32009
maybe square and cubic tests will bump code cov into the positive
AlexEdgcomb Dec 21, 2023
912077e
Check numeric value
AlexEdgcomb Dec 22, 2023
6e7f32b
Merge branch 'develop' into new-metric-prefixes
josdejong Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tests added for new prefixes
@AlexEdgcomb
AlexEdgcomb committed Dec 21, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
commit 7c2395b58d48ff60da6e4ce42540cab55b2fe093
27 changes: 27 additions & 0 deletions test/unit-tests/type/unit/Unit.test.js
View file
Original file line number Diff line number Diff line change
@@ -992,6 +992,33 @@ describe('Unit', function () {
assert.strictEqual(Unit.parse('5 millibar').toString(), '5 millibar')
assert.strictEqual(Unit.parse('5 mbar').toString(), '5 mbar')
})

it('should accept both long and short prefixes: Q, R, r, and q', function () {
assert.strictEqual(Unit.parse('5 quettameter').toString(), '5 quettameter')
assert.strictEqual(Unit.parse('5 Qm').toString(), '5 Qm')
assert.strictEqual(Unit.parse('5 ronnameter').toString(), '5 ronnameter')
assert.strictEqual(Unit.parse('5 Rm').toString(), '5 Rm')
assert.strictEqual(Unit.parse('5 rontometer').toString(), '5 rontometer')
assert.strictEqual(Unit.parse('5 rm').toString(), '5 rm')
assert.strictEqual(Unit.parse('5 quectometer').toString(), '5 quectometer')
assert.strictEqual(Unit.parse('5 qm').toString(), '5 qm')
})
})

describe('metric prefixes adopted by BIPM in 2022: Q(uetta), R(onna), r(onto), and q(uecto)', function () {
it('should accept long prefixes', function () {
assert.strictEqual(Unit.parse('5 quettameter').toString(), '5 quettameter')
assert.strictEqual(Unit.parse('5 ronnameter').toString(), '5 ronnameter')
assert.strictEqual(Unit.parse('5 rontometer').toString(), '5 rontometer')
assert.strictEqual(Unit.parse('5 quectometer').toString(), '5 quectometer')
})

it('should accept short prefixes', function () {
assert.strictEqual(Unit.parse('5 Qm').toString(), '5 Qm')
assert.strictEqual(Unit.parse('5 Rm').toString(), '5 Rm')
assert.strictEqual(Unit.parse('5 rm').toString(), '5 rm')
assert.strictEqual(Unit.parse('5 qm').toString(), '5 qm')
})
})

describe('_isDerived', function () {