remove contributors from package.json in favour of AUTHORS #1774
Conversation
Names present in package.json but not in commit logs
Most of these names have corresponding names in AUTHORS (e.g. Zach Zibrat is Zak Zibrat). Huseyn Guiliyev loses out though because he is noted as a contributor (due to participation in a number of issues I think) but hasn't committed to mathjs. I do not know how we can fix this though. |
Names in AUTHORS that were not in package.json
Some of these are legit AUTHORS whom we forgot to add to the package.json. There are also some duplicates that I haven't managed to mail map out. @josdejong you are also part of this list! |
|
Nice, I like it! It's indeed tricky not to forget to keep the list up to date. Maybe we should run the |
The contributors section of our package.json is _very_ long and manually updating can (?) be a pain. I took a leaf out of nodejs's book and copied their update-authors script [1]. [1]: https://github.com/nodejs/node/blob/master/tools/update-authors.js
|
None of our other npm-scripts change files tracked by git. I worry about the following senario: If a person "John Smith" a) makes a change the next time someone runs |
|
That's a good point. OK can you describe this step in the |
|
See b2172a3 It looks like I typed the commit message out in a hurry, should probably say |
|
Thanks again Harry, I've merged your PR! |
The contributors section of our package.json is very long and manually updating can be a pain.
I took a leaf out of nodejs's book and copied their update-authors script 1.
The new list is generated based on commits to the develop branch of mathjs (it is actually based on the current branch when the script is run) so the list is slightly different from the one from our package.json.