Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow dimensionless units #1251

Merged
merged 6 commits into from
Sep 15, 2018
Merged

Allow dimensionless units #1251

merged 6 commits into from
Sep 15, 2018

Conversation

ericman314
Copy link
Collaborator

Addresses #1240

@ericman314 ericman314 mentioned this pull request Sep 15, 2018
Closed
@josdejong
Copy link
Owner

😂 this is even less work than I expected @ericman314 , thanks!

Can you please fix the lint errors? (you can run linting locally via npm run lint)

@ericman314
Copy link
Collaborator Author

Yes, trying to fix them. I'm not used to the stricter rules.

@josdejong
Copy link
Owner

👍

I'm not used to the stricter rules.

yeah me too. It would help me if we set up a hook in git which runs npm run lint before pushing or something, I regularly fall in the same trap.

@josdejong josdejong merged commit 574c3b3 into josdejong:develop Sep 15, 2018
@ericman314 ericman314 deleted the unitless-values branch September 15, 2018 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericman314 @josdejong