Refactor jsonrepair.ts and core.ts to not use .charCodeAt
#140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, the use of
.charCodeAtwas introduced to improve performance. Some testing did show that in most cases, it doesn't actually improve the performance. It makes the code more verbose and harder to read though. Therefore, this PR refactorsjsonrepair.tsandcore.tsto not use.charCodeAt.There is one case where it actually helps to use
.charCodeAt: in the functionisWhiteSpaceand similar functions. In that case, we can move calling.charCodeAtinside the functionisWhiteSpace.