Remove the text from sitemap loading spinner #4
Conversation
| @@ -8,7 +8,7 @@ Alchemy.Sitemap = | |||
| @search_field = $("#search_field") | |||
| @filter_field_clear = $('.js_filter_field_clear') | |||
| @display = $('#page_filter_result') | |||
| @sitemap_wrapper = $('#sitemap-wrapper .sitemap-load-notice') | |||
| @sitemap_wrapper = $('#sitemap-wrapper') | |||
There was a problem hiding this comment.
The code replaces that target with the sitemap. There's some CSS attached to #sitemap-wrapper. This will break that. Instead, there should be a dummy element within the wrapper which can be safely replaced with the sitemap itself.
There was a problem hiding this comment.
I see you're using .replaceWith instead of .html that indeed replaces the element. Why?
There was a problem hiding this comment.
That's because the same code also replaces a part of the tree when folding. It's a lot less JS plumbing to just replace the entire unlinked list that's being folded. Now we don't need to disable the spinner, for example. Now folding is basically the same as rendering the whole tree. Just from a different root.
There was a problem hiding this comment.
That makes sense. I will change that this evening.
|
Thanks! I agree it looks better without text. I'll merge this asap. Probably this Monday. That's when I've got the whole rebase thing planned too. |
I'm still not satisfied, but I think this looks better without the text.