Skip to content

Commit

Permalink
add TODO comment
Browse files Browse the repository at this point in the history
  • Loading branch information
jorisvandenbossche committed Jun 26, 2024
1 parent 1b64ccf commit fe82b3e
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions cpp/src/arrow/pretty_print.cc
Original file line number Diff line number Diff line change
Expand Up @@ -392,6 +392,8 @@ class ArrayPrinter : public PrettyPrinter {

Status Print(const Array& array) {
if (array.device_type() != DeviceAllocationType::kCPU) {
// TODO: ideally we only copy start/end slice based on the window size that is being
// printed (requires CopyTo for slices https://github.com/apache/arrow/issues/43055)
ARROW_ASSIGN_OR_RAISE(auto array_cpu, array.CopyTo(default_cpu_memory_manager()));
RETURN_NOT_OK(VisitArrayInline(*array_cpu, this));
} else {
Expand Down

0 comments on commit fe82b3e

Please sign in to comment.