This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the functions
try_new -> Result<Self>
andnew -> Self
to every array.Background
The function named
from_data
is currently used to initialize arrays. This name comes from the original arrow-rs implementation, where there is a concept ofArrowData
. This concept is not used here, but the name "from_data" remained. Furthermore, this array currently panics, which means that it can only be used on trusted data.This PR
try_new
andnew
that align with most of Rust's ecosystem.try_new_unchecked
andnew_unchecked
for arrays whose validation isO(N)
(e.g. variable length, utf8).I have also (re-)audited all the invariants of every array to make sure they align with arrow's spec (they do).
Next steps
from_data
throughout the code base by eithertry_new
ornew
accordingly (depending on whether we expect the invariant to be held)from_data
?