Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Replaced assert by error in IPC read #748

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Replaced assert by error in IPC read #748

merged 1 commit into from
Jan 10, 2022

Conversation

jorgecarleitao
Copy link
Owner

Removed (hopefully last) assert from IPC read, thereby making IPC reading panic free.

@jorgecarleitao jorgecarleitao added the bug Something isn't working label Jan 10, 2022
@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #748 (a249de5) into main (4c29966) will decrease coverage by 0.01%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #748      +/-   ##
==========================================
- Coverage   70.82%   70.80%   -0.02%     
==========================================
  Files         313      313              
  Lines       16931    16937       +6     
==========================================
+ Hits        11992    11993       +1     
- Misses       4939     4944       +5     
Impacted Files Coverage Δ
src/io/ipc/read/read_basic.rs 66.35% <14.28%> (-3.95%) ⬇️
src/io/avro/read/schema.rs 55.91% <0.00%> (+1.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c29966...a249de5. Read the comment docs.

@jorgecarleitao jorgecarleitao changed the title Removed last assert from IPC read Replaced assert by error in IPC read Jan 10, 2022
@jorgecarleitao jorgecarleitao merged commit 3f6d522 into main Jan 10, 2022
@jorgecarleitao jorgecarleitao deleted the ipc_no_asserts branch January 10, 2022 06:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant