This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support to compare
months_days_nano
anddays_ms
intervals.Note that these types do not implement
partialOrd
(since there is no constraints over how many days are represented inms
or months indays
). Thus, the implementation can only exist foreq
andneq
, which is what this PR does.For this to happen, I had to split the trait
Simd8Lanes
in 3, so that we can describe the different constraints above in traits.The rest is just boilerplate to keep the code tidy and small.