Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Added and_scalar and or_scalar for boolean kleene #723

Conversation

silathdiir
Copy link
Contributor

Close #662

@codecov
Copy link

codecov bot commented Jan 2, 2022

Codecov Report

Merging #723 (7c0e285) into main (0311e22) will decrease coverage by 0.38%.
The diff coverage is 90.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #723      +/-   ##
==========================================
- Coverage   70.65%   70.26%   -0.39%     
==========================================
  Files         312      312              
  Lines       16894    17016     +122     
==========================================
+ Hits        11936    11956      +20     
- Misses       4958     5060     +102     
Impacted Files Coverage Δ
src/compute/boolean_kleene.rs 76.19% <90.47%> (+4.76%) ⬆️
src/io/ipc/read/array/union.rs 58.53% <0.00%> (-15.38%) ⬇️
src/io/ipc/read/array/struct_.rs 77.14% <0.00%> (-12.86%) ⬇️
src/io/ipc/read/array/primitive.rs 42.30% <0.00%> (-10.33%) ⬇️
src/io/ipc/read/array/null.rs 50.00% <0.00%> (-10.00%) ⬇️
src/io/ipc/read/schema.rs 80.64% <0.00%> (-9.79%) ⬇️
src/io/ipc/read/array/boolean.rs 40.74% <0.00%> (-9.26%) ⬇️
src/io/ipc/read/array/fixed_size_binary.rs 40.74% <0.00%> (-9.26%) ⬇️
src/io/ipc/read/array/fixed_size_list.rs 40.00% <0.00%> (-8.00%) ⬇️
src/io/ipc/read/array/utf8.rs 40.54% <0.00%> (-7.74%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0311e22...7c0e285. Read the comment docs.

@jorgecarleitao jorgecarleitao added the feature A new feature label Jan 2, 2022
@jorgecarleitao jorgecarleitao merged commit ef7937d into jorgecarleitao:main Jan 2, 2022
@silathdiir silathdiir deleted the add-and-scalar-and-or-scalar-to-boolean-kleene branch January 2, 2022 08:49
@jorgecarleitao
Copy link
Owner

Thanks a lot, @silathdiir , this is just flawless, so there is much to add xD

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add and_scalar and or_scalar for boolean_kleene
2 participants