Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Simplified Utf8Scalar and BinaryScalar #660

Merged
merged 1 commit into from
Dec 5, 2021
Merged

Simplified Utf8Scalar and BinaryScalar #660

merged 1 commit into from
Dec 5, 2021

Conversation

jorgecarleitao
Copy link
Owner

Made both to use Option<String> and Option<Vec<u8>> respectively. One less unsafe ^_^

@jorgecarleitao jorgecarleitao changed the title Simplified Utf8Scalar and BinaryScalar. Simplified Utf8Scalar and BinaryScalar Dec 5, 2021
@codecov
Copy link

codecov bot commented Dec 5, 2021

Codecov Report

Merging #660 (352b023) into main (a18555c) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #660      +/-   ##
==========================================
- Coverage   69.59%   69.56%   -0.04%     
==========================================
  Files         299      299              
  Lines       16746    16738       -8     
==========================================
- Hits        11655    11643      -12     
- Misses       5091     5095       +4     
Impacted Files Coverage Δ
src/compute/comparison/mod.rs 23.07% <ø> (ø)
src/scalar/binary.rs 92.85% <100.00%> (-1.59%) ⬇️
src/scalar/utf8.rs 92.85% <100.00%> (-1.59%) ⬇️
src/buffer/bytes.rs 40.00% <0.00%> (-16.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a18555c...352b023. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 021a8e3 into main Dec 5, 2021
@jorgecarleitao jorgecarleitao deleted the scalar_utf8 branch December 5, 2021 18:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant