Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Split "compute" feature #634

Merged
merged 1 commit into from
Nov 25, 2021
Merged

Split "compute" feature #634

merged 1 commit into from
Nov 25, 2021

Conversation

jorgecarleitao
Copy link
Owner

@jorgecarleitao jorgecarleitao commented Nov 25, 2021

The feature "compute" is a bit painful to compile. This PR splits the feature in individual features so that consumers can drag what they want from the compute module.

There is a longer-term solution of splitting the crate, but I am still figuring out what is the best approach for that. Meanwhile, with this people can go ahead and only drag the parts of the compute that they need :)

Backward incompatible changes

  • compute::concat -> compute::concatenate for consistency
  • feature regex was replaced by compute_regex_match and compute_like
  • feature merge_sort was renamed to compute_merge_sort

Other than this, the feature compute is now just an alias for the union of all compute_* features.

@ritchie46
Copy link
Collaborator

Very nice!

@codecov
Copy link

codecov bot commented Nov 25, 2021

Codecov Report

Merging #634 (f8cefcc) into main (c3222aa) will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #634   +/-   ##
=======================================
  Coverage   69.91%   69.92%           
=======================================
  Files         300      299    -1     
  Lines       16627    16627           
=======================================
+ Hits        11625    11626    +1     
+ Misses       5002     5001    -1     
Impacted Files Coverage Δ
src/compute/arithmetics/basic/div.rs 77.96% <ø> (ø)
src/compute/arithmetics/basic/mod.rs 0.00% <ø> (ø)
src/compute/arithmetics/decimal/add.rs 96.42% <ø> (ø)
src/compute/arithmetics/decimal/div.rs 92.30% <ø> (ø)
src/compute/arithmetics/decimal/mul.rs 92.30% <ø> (ø)
src/compute/arithmetics/decimal/sub.rs 96.36% <ø> (ø)
src/compute/arity.rs 77.33% <ø> (ø)
src/compute/concatenate.rs 100.00% <ø> (ø)
src/compute/contains.rs 34.00% <ø> (ø)
src/compute/if_then_else.rs 74.19% <ø> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3222aa...f8cefcc. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit e8279a4 into main Nov 25, 2021
@jorgecarleitao jorgecarleitao deleted the split_compute branch November 25, 2021 23:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants