Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Fixed error in reading nullable from Avro. #631

Merged
merged 1 commit into from
Nov 24, 2021
Merged

Fixed error in reading nullable from Avro. #631

merged 1 commit into from
Nov 24, 2021

Conversation

jorgecarleitao
Copy link
Owner

The deserializer assumed that the null variant was always the first of the union, which is not true.

@jorgecarleitao jorgecarleitao added the bug Something isn't working label Nov 24, 2021
@codecov
Copy link

codecov bot commented Nov 24, 2021

Codecov Report

Merging #631 (070e5e7) into main (439dacf) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #631      +/-   ##
==========================================
- Coverage   69.78%   69.77%   -0.02%     
==========================================
  Files         299      299              
  Lines       16667    16704      +37     
==========================================
+ Hits        11631    11655      +24     
- Misses       5036     5049      +13     
Impacted Files Coverage Δ
src/io/avro/read/deserialize.rs 72.64% <100.00%> (+1.47%) ⬆️
src/array/fixed_size_binary/mod.rs 73.00% <0.00%> (-6.72%) ⬇️
src/bitmap/utils/slice_iterator.rs 91.04% <0.00%> (-1.50%) ⬇️
src/compute/arithmetics/time.rs 46.93% <0.00%> (+2.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 439dacf...070e5e7. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 7f2c5bd into main Nov 24, 2021
@jorgecarleitao jorgecarleitao deleted the fix_avro branch November 24, 2021 18:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant