-
Notifications
You must be signed in to change notification settings - Fork 224
Compute: add partial option into CastOptions #561
Compute: add partial option into CastOptions #561
Conversation
de24d0a
to
19e61fc
Compare
Codecov Report
@@ Coverage Diff @@
## main #561 +/- ##
==========================================
+ Coverage 78.92% 79.04% +0.12%
==========================================
Files 382 395 +13
Lines 24276 24540 +264
==========================================
+ Hits 19160 19398 +238
- Misses 5116 5142 +26
Continue to review full report at Codecov.
|
@jorgecarleitao Hello, is there any problem with this change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. Missed this one. Thanks a lot for the PR!
Was not aware of the partial; cool concept. Left some comments: imo we should break the API, make CastOptions
first class, and remove the old APIs that were branching on the wrapping, as we now have 4 cases to cater for.
Looks awesome! Thanks a lot for the PR. |
Changes:
123 abc
- >123
closes #569