-
Notifications
You must be signed in to change notification settings - Fork 224
Conversation
Codecov Report
@@ Coverage Diff @@
## main #553 +/- ##
==========================================
+ Coverage 78.93% 78.95% +0.02%
==========================================
Files 382 385 +3
Lines 24288 24327 +39
==========================================
+ Hits 19171 19207 +36
- Misses 5117 5120 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a @1aguna for this. Looks great. Left a small number of suggestions, but it is otherwise ready to go. 👍
Co-authored-by: Jorge Leitao <[email protected]>
Co-authored-by: Jorge Leitao <[email protected]>
Co-authored-by: Jorge Leitao <[email protected]>
Co-authored-by: Jorge Leitao <[email protected]>
Thanks @jorgecarleitao ! I appreciate it 😄 |
One clippy and a conflict to go. Let me know if you would like me to address them for you. |
Alright I believe I resolved those issues. Hopefully passes the merge checks this time around. |
bitwise
operations
Adds bitwise
& and
,^ xor
,| or
, and! not
operators. This PR addresses #469 .Benchmarks on my machine are a little noisy, especially for the larger sizes, namely 2^20.
My system stats are
and here are the benchmarks for 2^20 for reference: