Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Made try_push_valid public again #509

Merged
merged 1 commit into from
Oct 9, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/array/list/mutable.rs
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,9 @@ impl<O: Offset, M: MutableArray> MutableListArray<O, M> {
}

#[inline]
fn try_push_valid(&mut self) -> Result<()> {
/// Needs to be called when a valid value was extended to this array.
/// This is a relatively low level function, prefer `try_push` when you can.
pub fn try_push_valid(&mut self) -> Result<()> {
let size = self.values.len();
let size = O::from_usize(size).ok_or(ArrowError::KeyOverflowError)?; // todo: make this error
assert!(size >= *self.offsets.last().unwrap());
Expand Down