Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Added read Decimal from parquet #489

Merged
merged 3 commits into from
Oct 6, 2021
Merged

Added read Decimal from parquet #489

merged 3 commits into from
Oct 6, 2021

Conversation

potter420
Copy link
Contributor

Hi,

This pull request address the issue #444

Thanks,

Copy link
Owner

@jorgecarleitao jorgecarleitao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks awesome, really great work here. Let me release a new parquet2 before we merge this so that we keep master releasable.

Cargo.toml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #489 (65512e7) into main (a15044a) will decrease coverage by 0.07%.
The diff coverage is 86.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #489      +/-   ##
==========================================
- Coverage   80.33%   80.26%   -0.08%     
==========================================
  Files         374      380       +6     
  Lines       22919    23464     +545     
==========================================
+ Hits        18413    18834     +421     
- Misses       4506     4630     +124     
Impacted Files Coverage Δ
src/io/parquet/read/schema/metadata.rs 79.06% <ø> (ø)
src/io/parquet/read/statistics/fixlen.rs 44.18% <44.18%> (ø)
src/io/parquet/read/mod.rs 60.00% <94.11%> (+6.98%) ⬆️
src/io/parquet/write/fixed_len_bytes.rs 90.69% <94.44%> (+2.23%) ⬆️
src/io/parquet/read/schema/convert.rs 91.31% <100.00%> (+0.83%) ⬆️
src/io/parquet/read/statistics/mod.rs 72.00% <100.00%> (+2.43%) ⬆️
src/io/parquet/read/statistics/primitive.rs 72.00% <100.00%> (+2.43%) ⬆️
tests/it/io/parquet/mod.rs 95.92% <100.00%> (+1.01%) ⬆️
tests/it/io/parquet/read.rs 98.76% <100.00%> (+0.21%) ⬆️
tests/it/io/parquet/write.rs 100.00% <100.00%> (ø)
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a15044a...65512e7. Read the comment docs.

@jorgecarleitao jorgecarleitao added the feature A new feature label Oct 6, 2021
@jorgecarleitao jorgecarleitao changed the title Add read Decimal from parquet file Added read Decimal from parquet Oct 6, 2021
@jorgecarleitao jorgecarleitao merged commit 2324a8f into jorgecarleitao:main Oct 6, 2021
@potter420 potter420 deleted the parquet-read-decimal branch October 6, 2021 11:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants