Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Added io_csv_read and io_csv_write feature #408

Merged
merged 3 commits into from
Sep 17, 2021

Conversation

ritchie46
Copy link
Collaborator

This feature gates io_csv into io_csv_read and io_csv_write in a backwards compatible manner.

io_csv = ["io_csv_read", "io_csv_write"]

closes #407

@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #408 (90fb423) into main (ee23796) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #408   +/-   ##
=======================================
  Coverage   80.96%   80.96%           
=======================================
  Files         347      347           
  Lines       22141    22201   +60     
=======================================
+ Hits        17927    17976   +49     
- Misses       4214     4225   +11     
Impacted Files Coverage Δ
src/io/csv/mod.rs 0.00% <ø> (ø)
src/compute/temporal.rs 83.78% <0.00%> (-10.07%) ⬇️
src/array/ord.rs 64.21% <0.00%> (-2.13%) ⬇️
tests/it/compute/temporal.rs 100.00% <0.00%> (ø)
src/compute/comparison/mod.rs 92.16% <0.00%> (ø)
src/compute/comparison/utf8.rs 67.41% <0.00%> (ø)
src/compute/comparison/binary.rs 67.41% <0.00%> (ø)
src/compute/comparison/boolean.rs 70.10% <0.00%> (ø)
src/compute/comparison/primitive.rs 91.01% <0.00%> (ø)
src/temporal_conversions.rs 84.15% <0.00%> (+1.98%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee23796...90fb423. Read the comment docs.

@jorgecarleitao
Copy link
Owner

Would you like to review this one @VasanthakumarV ?

@VasanthakumarV
Copy link
Contributor

Changes look good @jorgecarleitao

Only minutiae is whether, if we will need individual #[cfg_attr(docsrs, doc(cfg(feature = "io_csv")))] like attributes on the read and write module inside csv

Copy link
Owner

@jorgecarleitao jorgecarleitao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, @ritchie46 !

As @VasanthakumarV mentioned, we need the doc(cfg(feature = so that the API docs show the module with "This is supported on crate feature X only." (see https://docs.rs/arrow2/0.5.2/arrow2/compute/index.html).

src/io/csv/mod.rs Show resolved Hide resolved
src/io/csv/mod.rs Show resolved Hide resolved
@jorgecarleitao jorgecarleitao changed the title Splits csv_io feature into read/write Added io_csv_read and io_csv_write feature Sep 16, 2021
@jorgecarleitao jorgecarleitao merged commit d5cc0db into jorgecarleitao:main Sep 17, 2021
@jorgecarleitao jorgecarleitao added the enhancement An improvement to an existing feature label Sep 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement An improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants