This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Changed async ipc writer to accept schema by value #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1439 +/- ##
=======================================
Coverage 83.76% 83.76%
=======================================
Files 375 375
Lines 41027 41027
=======================================
+ Hits 34365 34367 +2
+ Misses 6662 6660 -2
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
jorgecarleitao
changed the title
ritchie46
added a commit
to ritchie46/arrow2
that referenced
this pull request
Mar 29, 2023
ritchie46
added a commit
to ritchie46/arrow2
that referenced
this pull request
Apr 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change we already made for the sync variant, but not for the async one.
We accept a
&Schemaas argument in theFileSinkconstructor and then we clone it. This is a bit wasteful, as users might have constructed the schema just before they passed it.