Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Made len/len_proxy consistent with Offsets #1434

Merged
merged 1 commit into from
Mar 19, 2023

Conversation

ritchie46
Copy link
Collaborator

We already renamed this in Offsets because it returned a counterintuitive len. This bit me again. ;)

This makes sure we are consistent with Offsets and OffsetsBuffer.

@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Patch coverage: 68.42% and project coverage change: -0.01 ⚠️

Comparison is base (db87f71) 83.76% compared to head (adf4571) 83.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1434      +/-   ##
==========================================
- Coverage   83.76%   83.76%   -0.01%     
==========================================
  Files         375      375              
  Lines       41024    41027       +3     
==========================================
+ Hits        34364    34366       +2     
- Misses       6660     6661       +1     
Impacted Files Coverage Δ
src/compute/aggregate/memory.rs 37.50% <0.00%> (ø)
src/offset.rs 84.87% <40.00%> (-0.89%) ⬇️
src/array/binary/mod.rs 91.82% <100.00%> (+1.44%) ⬆️
src/array/list/mod.rs 91.74% <100.00%> (ø)
src/array/map/mod.rs 62.13% <100.00%> (ø)
src/array/utf8/mod.rs 82.37% <100.00%> (ø)
src/io/parquet/write/pages.rs 95.84% <100.00%> (ø)

... and 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jorgecarleitao jorgecarleitao changed the title feat!: make len/len_proxy consistent with Offsets Made len/len_proxy consistent with Offsets Mar 19, 2023
@jorgecarleitao jorgecarleitao merged commit 574dab3 into jorgecarleitao:main Mar 19, 2023
ritchie46 added a commit to ritchie46/arrow2 that referenced this pull request Mar 21, 2023
ritchie46 added a commit to ritchie46/arrow2 that referenced this pull request Mar 29, 2023
ritchie46 added a commit to ritchie46/arrow2 that referenced this pull request Apr 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants