This repository has been archived by the owner on Feb 18, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently slicing arrays require cloning. This PR removes that requirement.
Backward incompatible changes
slice(&self, offset: usize, length: usize) -> Self
in all arrays and traitArray
changed signature toslice(&mut self, offset: usize, length: usize)
sliced(self, offset: usize, length: usize) -> Self
was added to all arrayssliced(&self, offset: usize, length: usize) -> Box<dyn Array>
was added to Array traitWith this new API:
&mut array
in place viaarray.slice(...)
array
vialet array = array.sliced(...);
&array
by cloning it and usingarray